[VDO-5752] [VDOSTORY-292] Add formatting logic #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
public testing running
public testing failed
and removed
untested
public testing running
labels
bjohnsto
force-pushed
the
feature/add_formatting
branch
from
57230c6 to
185361e
Compare
bjohnsto
force-pushed
the
feature/add_formatting
branch
from
185361e to
f42f855
Compare
Adds additional tests now that formatting actually works. Signed-off-by: Bruce Johnston <bjohnsto@redhat.com>
bjohnsto
force-pushed
the
feature/add_formatting
branch
from
b9a9209 to
1774c97
Compare
github-actions
bot
added
untested
private build running
public build running
private build done
private testing running
public build done
public testing running
private testing done
and removed
private testing done
private build done
public build done
public testing done
untested
private build running
public build running
private testing running
labels
lorelei-sakai
approved these changes
Dec 10, 2025
Member
lorelei-sakai
left a comment
lorelei-sakai
left a comment
There was a problem hiding this comment.
Yeah, okay. I think this is all dealt with now.
Looks good.
Member
Author
Thanks for all the reviews Matt |
bjohnsto
merged commit 88c25e6
into
dm-vdo:feature/add-vdoformat-into-kernel
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commits is the final set of changes for moving vdoformat into the kernel. The changes add the logic for when to format or not and the actual layout initialization and writing of the layout to disk when formatting is needed. Additionally, it adds unit test support and more functional tests to the VDOFormatInKernel.pm perl test.