Feat: Add CPU model and topology support

[NamelessOne91]

Related to:

• Feature request; CPU topology, sockets, cores, threads #686
• xml parameter or match, model, check are not available under cpu block for a domain #1119
• set custom cpu model - to enable kvm live migration #1020

Adds support for defining model and topology blocks on a libvirt domain's CPU.
This is possible with 2 limitations:

• to define a model, the CPU mode must be set to "custom"
• sockets * threads * cores must be <= to the number of vCPU

Example:

resource "libvirt_domain" "test-domain" {
    name = "test"
    vcpu = 4
    cpu  {
        mode = "custom"
        model {
            fallback = "forbid"
            value = "EPYC"
            vendor_id = "AuthenticAMD"
        }
        topology {
            sockets = 1
            cores = 2
            threads = 2
        }
    }
}

[bradthebuilder]

I wasn't able to get a aarch64 VM to spawn until I tried using this PR. Worked like a charm!

[localghost]

@dmacvicar any plans to iterate "over interesting PRs and do minor improvements" (specifically this one) in the near future?

[Freebien]

@dmacvicar this one would be of great help to use arm64 easily

[localghost]

@Freebien

If that would be of help then https://registry.terraform.io/providers/localghost/libvirt/0.1.0 is v0.8.3 with this PR applied.

Please don't use v0.2.0, it has some experimental changes included additionally.

[Freebien]

@Freebien

If that would be of help then https://registry.terraform.io/providers/localghost/libvirt/0.1.0 is v0.8.3 with this PR applied.

Please don't use v0.2.0, it has some experimental changes included additionally.

Thanks, I'll do that for the time being I think !

[dmacvicar]

ℹ️ ℹ️ ℹ️ ℹ️ ℹ️ ℹ️

This contribution is relevant to the legacy version of the provider, which is now in the v0.8 branch of this repository.

Future development is based on a new provider, which is not compatible with this one, nor does share code.

As the new provider solves many issues with the legacy, and to make development in my free time more enjoyable, I have decided to close all PRs for the legacy provider, and to ask to check if the contribution would apply to the new one. This also to encourage trying the new version.

• https://registry.terraform.io/providers/dmacvicar/libvirt/latest

and check the documentation:

• https://github.com/dmacvicar/terraform-provider-libvirt/blob/main/README.md
• https://registry.terraform.io/providers/dmacvicar/libvirt/latest/docs

You are free to reopen the PR for v0.8, which is targetted now to the v0.8 branch. We may also start a discussion if we can assemble a team of maintainters for the legacy branch. My efforts will go into the new provider.

I ask you to check the new provider and re-evaluate this contribution. 🙏