cli_tool: Add CLI options to configure lightness range.#56
Open
prakhar1144 wants to merge 1 commit intodmester:masterfrom
Open
cli_tool: Add CLI options to configure lightness range.#56prakhar1144 wants to merge 1 commit intodmester:masterfrom
prakhar1144 wants to merge 1 commit intodmester:masterfrom
Conversation
Earlier, the CLI options offered doesn't include option to configure lightness range of colored and grayscale shapes. The npm package itself has options to configure these, but was not exposed via CLI tool. This commit makes changes to add the following two options: * --lightness-color * --lightness-grayscale Signed-off-by: Prakhar Pratyush <prakhar1144@gmail.com>
prakhar1144
force-pushed
the
cli-options-lightness-range
branch
from
e12eb7b to
1d7b1ab
Compare
Author
|
@dmester A gentle ping for reviewing this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the CLI options offered doesn't include option to configure lightness range of colored and grayscale shapes.
The npm package itself has options to configure these, but not exposed via CLI tool.
This PR makes changes to add the following two options:
Testing:
We're using this project at Zulip. We've patched the changes & tested it for our use case.
Example screenshots (took extreme values to easily confirm that it works):
Thanks for creating & maintaining this project.