mxl-sink: Fix wrong write video/audio offset#430
Open
pedro-alves-ferreira wants to merge 1 commit intodmf-mxl:mainfrom
Open
mxl-sink: Fix wrong write video/audio offset#430pedro-alves-ferreira wants to merge 1 commit intodmf-mxl:mainfrom
pedro-alves-ferreira wants to merge 1 commit intodmf-mxl:mainfrom
Conversation
Signed-off-by: Simao Fonseca <simao.fonseca@bisect.pt>
SimaoFonseca2
force-pushed
the
fix/network-stream-write
branch
from
c63de18 to
cd51cad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the mxl-sink write algorithm so that writes to the circular buffer are delayed until just before their presentation time.
This avoids overflowing the buffer in case the video and audio streams are received at significantly different times, e.g. as occurs in MPEG TS.