Comprehensive implementation of all 5 issues (#49-55) #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues resolved: - dmphillippo#49: Enhanced multicollinearity detection in add_integration() - dmphillippo#52: TTE parametric distribution ranking warnings - dmphillippo#53: Return knot locations from spline-based likelihoods - dmphillippo#54: MCMC convergence diagnostics functions - dmphillippo#55: Fix exchangeable classes with single treatments Changes include: - 306 lines of new MCMC diagnostic functionality - 88 lines of multicollinearity detection with comprehensive validation - Automatic knot location storage for mspline/pexp models - Warning system for TTE ranking ambiguity - 21 Stan file fixes for array bounds checking - 1000+ lines of comprehensive test coverage - Full backward compatibility maintained - Production-ready implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues resolved:
Changes include: