Skip to content

fix(security): SSRF protection always-on + path traversal guard on uploads #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
docdyhr merged 1 commit into from
Mar 26, 2026
Merged

fix(security): SSRF protection always-on + path traversal guard on uploads #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/client/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,9 @@ export class WordPressClient implements IWordPressClient {
throw new Error("Only HTTP and HTTPS protocols are allowed");
}

// Prevent localhost/private IP access in production
if (config().app.isProduction) {
// Prevent localhost/private IP access unless explicitly allowed
// Set ALLOW_PRIVATE_URLS=true for local development with a local WordPress
if (process.env.ALLOW_PRIVATE_URLS !== "true") {
const hostname = parsed.hostname.toLowerCase();
if (
hostname === "localhost" ||
Expand All @@ -267,7 +268,7 @@ export class WordPressClient implements IWordPressClient {
hostname.match(/^172\.(1[6-9]|2[0-9]|3[01])\./) ||
hostname.match(/^192\.168\./)
) {
throw new Error("Private/localhost URLs not allowed in production");
throw new Error("Private/localhost URLs not allowed. Set ALLOW_PRIVATE_URLS=true for local development.");
}
}

Expand Down
11 changes: 9 additions & 2 deletions src/tools/media.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { WordPressClient } from "@/client/api.js";
import type { MCPToolSchema } from "@/types/mcp.js";
import { MediaQueryParams, UpdateMediaRequest, UploadMediaRequest } from "@/types/wordpress.js";
import { getErrorMessage } from "@/utils/error.js";
import { validateFilePath } from "@/utils/validation/security.js";
import { toolParams } from "./params.js";

/**
Expand Down Expand Up @@ -223,10 +224,16 @@ export class MediaTools {
public async handleUploadMedia(client: WordPressClient, params: Record<string, unknown>): Promise<unknown> {
const uploadParams = toolParams<UploadMediaRequest & { file_path: string }>(params);
try {
// Validate file path to prevent path traversal attacks
// Set MCP_UPLOAD_BASE_DIR to restrict uploads to a specific directory (recommended in Docker)
const allowedBasePath = process.env.MCP_UPLOAD_BASE_DIR || "/";
const safePath = validateFilePath(uploadParams.file_path, allowedBasePath);
uploadParams.file_path = safePath;

try {
await fs.promises.access(uploadParams.file_path);
await fs.promises.access(safePath);
} catch (_error) {
throw new Error(`File not found at path: ${uploadParams.file_path}`);
throw new Error(`File not found at path: ${safePath}`);
}

const media = await client.uploadMedia(uploadParams);
Expand Down
Loading