fix: Correct benchmarks import path in advanced CI/CD pipeline#110
Merged
fix: Correct benchmarks import path in advanced CI/CD pipeline#110
Conversation
The performance-tests job imported from `versiontracker.benchmarks` which doesn't exist. The module lives at `versiontracker.experimental.benchmarks`. This has caused the daily scheduled pipeline to fail since at least March 6. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the advanced CI/CD workflow to import performance benchmark utilities from their correct experimental package location so the scheduled performance tests can run without ModuleNotFoundError failures. Sequence diagram for advanced CI performance benchmarks import fixsequenceDiagram
actor Scheduler
participant GitHubActions as GitHub_Actions
participant AdvancedCI as Advanced_CI_Workflow
participant PerfJob as performance_tests_job
participant Python as Python_interpreter
participant Benchmarks as versiontracker_experimental_benchmarks
Scheduler->>GitHubActions: Trigger daily_schedule
GitHubActions->>AdvancedCI: Start workflow advanced-ci.yml
AdvancedCI->>PerfJob: Run performance benchmarks step
PerfJob->>Python: Execute python -c script
Python->>Benchmarks: import create_benchmark_suite
Python->>Benchmarks: import VersionTrackerBenchmarks
Benchmarks-->>Python: Export benchmark utilities
Python->>Benchmarks: create_benchmark_suite()
Benchmarks-->>Python: suite
Python->>PerfJob: Exit code 0 if success
PerfJob-->>AdvancedCI: Benchmarks completed
AdvancedCI->>PerfJob: Run performance regression step
PerfJob->>Python: Execute python -c script
Python->>Benchmarks: import run_performance_regression_test
Benchmarks-->>Python: Export regression test helper
Python->>Benchmarks: run_performance_regression_test()
Benchmarks-->>Python: no_regression flag
Python-->>PerfJob: Exit with failure if regression
PerfJob-->>AdvancedCI: Regression check result
AdvancedCI-->>GitHubActions: Workflow status
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since
experimentalpaths are more likely to move, consider centralizing the benchmark module path in a single shell/env variable or reusable workflow block so future relocations don’t require editing multiple inline Python snippets. - You might add a lightweight import check step earlier in the workflow (e.g.,
python -c 'import versiontracker.experimental.benchmarks') so similar module resolution issues fail fast rather than only surfacing during the benchmark run.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since `experimental` paths are more likely to move, consider centralizing the benchmark module path in a single shell/env variable or reusable workflow block so future relocations don’t require editing multiple inline Python snippets.
- You might add a lightweight import check step earlier in the workflow (e.g., `python -c 'import versiontracker.experimental.benchmarks'`) so similar module resolution issues fail fast rather than only surfacing during the benchmark run.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
🔒 Security Analysis ReportSecurity Analysis ReportGenerated: Mon Mar 9 09:06:31 UTC 2026 Bandit Security ScanSafety Check ResultsPip-Audit Results |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModuleNotFoundError: No module named 'versiontracker.benchmarks'in the daily scheduled Advanced CI/CD Pipelineversiontracker.benchmarkstoversiontracker.experimental.benchmarks(where the module actually lives)Test plan
🤖 Generated with Claude Code
Summary by Sourcery
CI: