Conversation
…currency - README: Add CI test matrix table (Python 3.12/3.13 × Ubuntu/macOS) - README: Update version to 0.9.0, test count to 1,885+, date to March 2026 - lint.yml: Standardize mypy options to --ignore-missing-imports (matches ci.yml) - codeql-analysis.yml: Add concurrency group (cancel-in-progress: true) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates documentation badges and metadata to reflect current CI status and test metrics, standardizes mypy options in the lint workflow to match other checks, and adds a concurrency group to the CodeQL workflow to avoid overlapping runs. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The new test matrix table shows separate columns for Python 3.12 and 3.13 but all four badges point to the same generic CI workflow URL and label, which might be misleading; consider differentiating the badges (e.g., via labels or query params) or clarifying in text that they represent the same workflow across versions.
- The README now states "~61% overall test coverage" while the coverage badge still advertises "70%+"; it would be good to align these numbers or explicitly explain the difference (e.g., per-module vs overall coverage) to avoid confusion.
- In lint.yml, switching from the previous stricter MyPy configuration to only
--ignore-missing-importssubstantially relaxes type checking; if that’s intentional, consider adding a brief comment in the workflow to document the rationale for future maintainers.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new test matrix table shows separate columns for Python 3.12 and 3.13 but all four badges point to the same generic CI workflow URL and label, which might be misleading; consider differentiating the badges (e.g., via labels or query params) or clarifying in text that they represent the same workflow across versions.
- The README now states "~61% overall test coverage" while the coverage badge still advertises "70%+"; it would be good to align these numbers or explicitly explain the difference (e.g., per-module vs overall coverage) to avoid confusion.
- In lint.yml, switching from the previous stricter MyPy configuration to only `--ignore-missing-imports` substantially relaxes type checking; if that’s intentional, consider adding a brief comment in the workflow to document the rationale for future maintainers.
## Individual Comments
### Comment 1
<location path="README.md" line_range="107-109" />
<code_context>
Versiontracker is a command-line tool for macOS that helps you manage applications
installed outside of the App Store. Recently undergone complete technical debt cleanup
-with **70%+ test coverage** and **all high & medium-priority complexity issues resolved**.
+with **1,885+ passing tests** and **all high & medium-priority complexity issues resolved**.
It identifies applications that aren't managed through Apple's official channels and suggests which ones can be managed
</code_context>
<issue_to_address>
**suggestion (typo):** Consider fixing the sentence fragment starting with "Recently undergone complete technical debt cleanup" for better grammar.
For example, you could rewrite it as: "It has recently undergone a complete technical debt cleanup with ..." to make the sentence complete and grammatically correct.
```suggestion
Versiontracker is a command-line tool for macOS that helps you manage applications
installed outside of the App Store. It has recently undergone a complete technical debt cleanup
with **1,885+ passing tests** and **all high & medium-priority complexity issues resolved**.
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
107
to
+109
| Versiontracker is a command-line tool for macOS that helps you manage applications | ||
| installed outside of the App Store. Recently undergone complete technical debt cleanup | ||
| with **70%+ test coverage** and **all high & medium-priority complexity issues resolved**. | ||
| with **1,885+ passing tests** and **all high & medium-priority complexity issues resolved**. |
Contributor
There was a problem hiding this comment.
suggestion (typo): Consider fixing the sentence fragment starting with "Recently undergone complete technical debt cleanup" for better grammar.
For example, you could rewrite it as: "It has recently undergone a complete technical debt cleanup with ..." to make the sentence complete and grammatically correct.
Suggested change
| Versiontracker is a command-line tool for macOS that helps you manage applications | |
| installed outside of the App Store. Recently undergone complete technical debt cleanup | |
| with **70%+ test coverage** and **all high & medium-priority complexity issues resolved**. | |
| with **1,885+ passing tests** and **all high & medium-priority complexity issues resolved**. | |
| Versiontracker is a command-line tool for macOS that helps you manage applications | |
| installed outside of the App Store. It has recently undergone a complete technical debt cleanup | |
| with **1,885+ passing tests** and **all high & medium-priority complexity issues resolved**. |
🔒 Security Analysis ReportSecurity Analysis ReportGenerated: Wed Mar 18 17:09:52 UTC 2026 Bandit Security ScanSafety Check ResultsPip-Audit Results |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.8.1→0.9.0, test count1,230+→1,885+, date to March 2026--ignore-missing-imports(was using different flags thanci.yml, causing inconsistency between the two linting checks)concurrencygroup withcancel-in-progress: true(the only workflow missing it)Test plan
lint.ymlmypy check passes with standardized options🤖 Generated with Claude Code
Summary by Sourcery
Update documentation and CI workflows to reflect current test coverage, standardize type-checking configuration, and improve CodeQL execution safety.
Enhancements:
Documentation: