Skip to content

Conversation

@vagenas
Copy link
Collaborator

@vagenas vagenas commented Nov 7, 2025

Suggests deprecating use_legacy_mode param & deriving whether to use "legacy" annotations (i.e. .annotations) as defined in _should_use_legacy_annotations() (which also takes care of preventing unnecessary warnings).

Through this change, even DoclingDocuments created with enrichments (e.g. visual captioning) and without going through Pydantic validation/migration will be able to have their (legacy) annotations serialized.

Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
@vagenas vagenas requested a review from ceberam November 7, 2025 15:35
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

DCO Check Passed

Thanks @vagenas, all your commits are properly signed off. 🎉

@mergify
Copy link

mergify bot commented Nov 7, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

🟢 Require two reviewer for test updates

Wonderful, this rule succeeded.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

@codecov
Copy link

codecov bot commented Nov 7, 2025

@vagenas vagenas marked this pull request as ready for review November 12, 2025 10:48
@dosubot
Copy link

dosubot bot commented Nov 12, 2025

Related Documentation

Checked 3 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Copy link
Contributor

@cau-git cau-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vagenas vagenas merged commit 3d13b02 into main Nov 12, 2025
12 of 13 checks passed
@vagenas vagenas deleted the fix-meta-warnings branch November 12, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants