Skip to content

Fix working with proxy servers #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix working with proxy servers #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ systemfiles = [
process.env.NODE_UNICODETABLE_UNICODEDATA_TXT || "UnicodeData.txt", // manually downloaded
],
unicodedatafile = {
scheme: "http",
host: "unicode.org",
path: "/Public/UNIDATA/UnicodeData.txt",
method: 'GET',
Expand Down Expand Up @@ -123,7 +124,7 @@ function read_file(success_cb, error_cb) {

function download_file(callback) {
var timeouthandle = null;
console.log("%s %s:%d%s", unicodedatafile.method, unicodedatafile.host,
console.log("%s %s://%s:%d%s", unicodedatafile.method, unicodedatafile.scheme, unicodedatafile.host,
Copy link

@nalbion nalbion Aug 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also needs to be added below within if (proxyServer)... unicodedatafile.path = unicodedatafile.scheme + "://" + unicodedatafile.host

this would then resolve many issues on dependant projects:
dodo/node-slug#58
keystonejs/generator-keystone#129

the symptom I'm seeing is Error: Cannot find module 'unicode/category/So'

unicodedatafile.port, unicodedatafile.path);

if (proxyServer) {
Expand Down