Match ef_061D 100% and rename to efspecial (special effects)#2241
Match ef_061D 100% and rename to efspecial (special effects)#2241hourianto wants to merge 10 commits intodoldecomp:masterfrom
Conversation
|
Regarding what you said about re-implementing inlines, was that in regards to what I commented on? |
|
@PsiLupan not exactly, I was referring to the macro hackery with defines/includes at the top of the file. Regarding the ones inside the function - I'll see what's possible, but it was extremely brittle, took some time to get it right, but yeah I'll see if now it's stable enough to use those. |
8293c3e to
98d8d8f
Compare
ribbanya
left a comment
There was a problem hiding this comment.
The merge conflicts need to be resolved more cleanly. We should probably hold off on renaming the file until just before merging the PR.
fbfff3e to
0079c1a
Compare
Ended up just renaming efSync_SpawnSpecial and then merging using -X ours
|
Unfortunately, this PR does not improve the quality of the code for this function, and it's already been matched upstream. The file can be renamed in a separate PR. |
Mostly done by GPT 5.4 with a tiny part of Opus 4.6. GPT 5.4 struggled in some sections a lot but eventually got it. It created some helpful local tooling for itself which it'll improve based on the experience. There might still be problems, but from the tooling I tried it's clean, and the final game file has the same hash.
The macro things are really ugly but the only other solutions it suggested were tons of defines or duplicating inline functions from other modules, which I didn't like, but maybe my approach was wrong.