Skip to content

Match ef_061D 100% and rename to efspecial (special effects)#2241

Closed
hourianto wants to merge 10 commits intodoldecomp:masterfrom
hourianto:efspecial-submit
Closed

Match ef_061D 100% and rename to efspecial (special effects)#2241
hourianto wants to merge 10 commits intodoldecomp:masterfrom
hourianto:efspecial-submit

Conversation

@hourianto
Copy link
Contributor

@hourianto hourianto commented Mar 8, 2026

Mostly done by GPT 5.4 with a tiny part of Opus 4.6. GPT 5.4 struggled in some sections a lot but eventually got it. It created some helpful local tooling for itself which it'll improve based on the experience. There might still be problems, but from the tooling I tried it's clean, and the final game file has the same hash.

The macro things are really ugly but the only other solutions it suggested were tons of defines or duplicating inline functions from other modules, which I didn't like, but maybe my approach was wrong.

@decomp-dev
Copy link

decomp-dev bot commented Mar 8, 2026

Report for GALE01 (fca0de8 - dfedfb8)

📈 2 improvements in unmatched items
Unit Item Bytes Before After
main/melee/ef/efsync efSync_Spawn +1 95.90% 95.91%
main/melee/ef/efasync efAsync_80063930 +1 98.46% 98.46%

@PsiLupan
Copy link
Collaborator

PsiLupan commented Mar 8, 2026

Regarding what you said about re-implementing inlines, was that in regards to what I commented on?

@hourianto
Copy link
Contributor Author

@PsiLupan not exactly, I was referring to the macro hackery with defines/includes at the top of the file. Regarding the ones inside the function - I'll see what's possible, but it was extremely brittle, took some time to get it right, but yeah I'll see if now it's stable enough to use those.

@ribbanya ribbanya self-assigned this Mar 15, 2026
Copy link
Collaborator

@ribbanya ribbanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The merge conflicts need to be resolved more cleanly. We should probably hold off on renaming the file until just before merging the PR.

@ribbanya ribbanya force-pushed the efspecial-submit branch 2 times, most recently from fbfff3e to 0079c1a Compare March 15, 2026 19:12
@ribbanya ribbanya dismissed their stale review March 15, 2026 19:17

Ended up just renaming efSync_SpawnSpecial and then merging using -X ours

@ribbanya
Copy link
Collaborator

Unfortunately, this PR does not improve the quality of the code for this function, and it's already been matched upstream. The file can be renamed in a separate PR.

@ribbanya ribbanya closed this Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants