it: match 14 item functions#2300
Merged
PsiLupan merged 6 commits intodoldecomp:masterfrom Mar 15, 2026
Merged
Conversation
Report for GALE01 (b8e78ea - a35d851)📈 Matched code: 58.05% (+0.06%, +2328 bytes) ✅ 15 new matches
📈 4 improvements in unmatched items
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…otion0_Coll, itGamewatchchef_UnkMotion1_Coll Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…n2_Phys, it_802D1DD8 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…n2_Phys, it_802D2B4C, it_802D2C78 Decompile four functions in ithouou.c (Ho-Oh Pokemon item): - it_2725_Logic18_Spawned: Pokemon spawn initialization - itHouou_UnkMotion2_Phys: Motion state 2 physics (ascent with blast zone check) - it_802D2B4C: Accessory callback (fire breath spawning) - it_802D2C78: State transition on hit detection Also updates itHououAttr struct fields (x8, xC, x14) and it_802D2B4C/it_802D2D2C header signatures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
itClimbersice_UnkMotion0_Anim(48 bytes)it_802C84A0,itGamewatchchef_UnkMotion0_Coll,itGamewatchchef_UnkMotion1_Coll(40–80 bytes)it_802B211C,it_802B22B8(56–72 bytes)it_2725_Logic17_Spawned,itLugia_UnkMotion2_Phys,it_802D1DD8(28–64 bytes)it_2725_Logic18_Spawned,itHouou_UnkMotion2_Phys,it_802D2B4C,it_802D2C78(28–80 bytes)it_802D73F0(140 bytes)Verification
ninjabuilds cleanlyWhat these functions do
Pokeball summon callbacks for Lugia and Ho-Oh — spawn initialization, physics during flight, and the damage-on-contact logic that fires when they sweep across the stage. The Goomba (
itOldkuri) initializer resets velocity and picks a patrol direction when spawning on Mushroom Kingdom. Ice Climbers' ice block (itClimbersice) handles the animation tick for the frozen projectile. Mr. Game & Watch's chef (itGamewatchchef) sausage projectiles get their collision callbacks for bouncing off platforms. The Pikachu Thunder (itpikachuthunder) functions handle the lightning bolt's downward travel logic.🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com