Merged
Conversation
Report for GALE01 (19a42a2 - 46b8a41)📈 Matched code: 58.00% (+0.02%, +620 bytes) ✅ 4 new matches
📈 2 improvements in unmatched items
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Implement three functions in the name entry menu system: - mnName_GetPageCount: counts valid names, returns ceil(count/24) — 100% match - mnName_GetColumnCount: counts valid names, returns ceil(count/6) — 97.9% match (1 instruction regalloc diff, same pre-existing issue as IsNameListFull) - mnName_802388D4: gets JObj at keyboard key index via child traversal — 100% match Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fn_8018846Cmn_80232458mnName_GetPageCount,mnName_GetColumnCount,mnName_802388D4Verification
ninjabuilds cleanlyWhat these functions do
Menu and game-mode utilities.
fn_8018846Cis a game-state callback in the results/ranking screen flow.mn_80232458handles logic in the Rules menu screen. The threemnNamefunctions support the Name Entry screen —GetPageCountandGetColumnCountcalculate pagination for the 120-slot name list (pages of 24, columns of 6), and802388D4is a layout callback for rendering the scrollable name grid.🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com