Skip to content

Improve accuracy on the mwerks sdk#86

Open
hyblocker wants to merge 2 commits intodoldecomp:mainfrom
hyblocker:chore/improve-mwerks-sdk
Open

Improve accuracy on the mwerks sdk#86
hyblocker wants to merge 2 commits intodoldecomp:mainfrom
hyblocker:chore/improve-mwerks-sdk

Conversation

@hyblocker
Copy link
Contributor

matches ansi_fp and notify 100%, improves support a bit to 99.64% accuracy

@decomp-dev
Copy link

decomp-dev bot commented Feb 24, 2026

Report for GMSJ01 (5461746 - 718e768)

📈 Matched code: 27.66% (+0.01%, +216 bytes)
📈 Linked code: 13.21% (+0.01%, +216 bytes)

✅ 1 new match
Unit Item Bytes Before After
mario/TRK_MINNOW_DOLPHIN/debugger/embedded/MetroTRK/Portable/notify TRKDoNotifyStopped +1 99.96% 100.00%

@hyblocker hyblocker force-pushed the chore/improve-mwerks-sdk branch from 89f414e to 718e768 Compare March 13, 2026 10:36

error = TRKRequestSend(buffer, &replyBufferId, read ? 5 : 5, 3,
!(read && file_handle == 0));
error = (0, TRKRequestSend(buffer, &replyBufferId, read ? 5 : 5,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bruh... almost definitely a fakematch, no? better to leave non-matching than to force it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants