Skip to content

Refactor SMS_EmitSinkInPollutionEffect vector normalization#91

Open
FranCarnovale wants to merge 3 commits intodoldecomp:mainfrom
FranCarnovale:main
Open

Refactor SMS_EmitSinkInPollutionEffect vector normalization#91
FranCarnovale wants to merge 3 commits intodoldecomp:mainfrom
FranCarnovale:main

Conversation

@FranCarnovale
Copy link

Improved match on SMS_EmitSinkInPollutionEffect.
Removed temps, and just normalized C and B.

Refactor SMS_EmitSinkInPollutionEffect to normalize vectors in place
@decomp-dev
Copy link

decomp-dev bot commented Mar 12, 2026

Report for GMSJ01 (5461746 - 544f2f8)

📈 1 improvement in an unmatched item
Unit Item Bytes Before After
mario/MarioUtil/EffectUtil SMS_EmitSinkInPollutionEffect(const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, bool) +10 96.66% 98.75%

commit a65f5ac
Author: Roman Sandu <roma.sandu@gmail.com>
Date:   Sun Mar 15 01:40:13 2026 +0300

    Clanker-powered CardSave
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant