Skip to content

Some work on GCConsole2#93

Open
lingomaniac88 wants to merge 11 commits intodoldecomp:mainfrom
lingomaniac88:gcconsole2-partial-1
Open

Some work on GCConsole2#93
lingomaniac88 wants to merge 11 commits intodoldecomp:mainfrom
lingomaniac88:gcconsole2-partial-1

Conversation

@lingomaniac88
Copy link
Contributor

GCConsole2 is the largest TU, so I figure I might as well try to help chip away at it.

I'm not being too aggressive with renaming or retyping members of TGCConsole2 (the J2DPicture casts look suspicious though), but I imagine we can resolve those better once we study how these members are used more thoroughly.

@decomp-dev
Copy link

decomp-dev bot commented Mar 15, 2026

Report for GMSJ01 (a65f5ac - 4f71898)

📈 Matched code: 27.78% (+0.07%, +2640 bytes)

✅ 7 new matches
Unit Item Bytes Before After
mario/GC2D/GCConsole2 TGCConsole2::startDownLeftBot() +960 0.41% 100.00%
mario/GC2D/GCConsole2 TGCConsole2::startInsertTimer() +409 0.97% 100.00%
mario/GC2D/GCConsole2 TGCConsole2::startDisappearTelop() +324 1.22% 100.00%
mario/GC2D/GCConsole2 TGCConsole2::startAppearCoin() +313 1.27% 100.00%
mario/GC2D/GCConsole2 TGCConsole2::startDisappearTimer() +301 1.32% 100.00%
mario/GC2D/GCConsole2 TGCConsole2::resetLife(int) +261 1.52% 100.00%
mario/GC2D/GCConsole2 TCoord2D::roundf<int>(float) const +52 0.00% 100.00%
📈 6 improvements in unmatched items
Unit Item Bytes Before After
mario/GC2D/GCConsole2 TGCConsole2::setTimer(long) +1080 0.35% 96.12%
mario/GC2D/GCConsole2 TGCConsole2::startDisappearCoin() +714 0.56% 99.77%
mario/GC2D/GCConsole2 TGCConsole2::startAppearTimer(int, long) +520 0.76% 99.82%
mario/GC2D/GCConsole2 TGCConsole2::startAppearTelop(bool) +464 0.85% 99.34%
mario/GC2D/GCConsole2 TGCConsole2::startAppearTank() +286 1.37% 99.32%
mario/GC2D/GCConsole2 .sdata2 +41 12.77% 36.94%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant