add interval fetching list on discover node#18
Open
aladhims wants to merge 3 commits intodonkeysharp:masterfrom
Open
add interval fetching list on discover node#18aladhims wants to merge 3 commits intodonkeysharp:masterfrom
aladhims wants to merge 3 commits intodonkeysharp:masterfrom
Conversation
donkeysharp
requested changes
Oct 7, 2019
Owner
donkeysharp
left a comment
donkeysharp
left a comment
There was a problem hiding this comment.
I added a small observation, with that change I will merge your changes
donkeysharp
requested changes
Oct 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As raised in issue #14, it needs some kind of interval fetching for discover node in order to keep up to date with the newer list