-
Notifications
You must be signed in to change notification settings - Fork 19
Felipe moreira #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Felipe-Camargo12
wants to merge
54
commits into
dorotech:main
Choose a base branch
from
Felipe-Camargo12:felipe-moreira
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Felipe moreira #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ainda terá alterações
…ema claro e escuro
… logo e seleção de tema
…cada personagem trago da requisição
…bidos por página (5, 10 ou 20)
…a dar retorno visual de resposta ao usuário
…ntes implementados
Eliminado comportamento que fazia a aplicação buscar as 42 páginas da API. Criado endpoint interno `/api/options` para filtrar as opções de especies e tipos e fazer somente 1 requisição, passado para filters. Alteração no getCharacters, criado objeto apiPage, requisita apenas a página atual substituindo o comportamento antigo que fazia várias requisições em loop. Ajuste no homeWrapper para dividir os resultados da busca entre "info" e "results"(characters) As lógicas de getCharacters e getOptions faziam loop para verificar as informações, agora options esta do lado do server e os personagens são chamados página por página, utilizando "info" apenas para paginação.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teste de frontend developer finalizado, implementado portal requerido.