-
Notifications
You must be signed in to change notification settings - Fork 377
[WIP] Use NET=Runtime on tasks and delete .NET Framework task implementations #16413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Two blockers so far:
Slightly related: There a few remaining tools(!) / libraries that still target .NET Framework that I'm not sure about: Helix.Client, Helix.JobSender, StrongName, SignCheck and SignCheckLibrary. I wonder if all those need to stay on .NET Framework? |
4c79025 to
c0c2104
Compare
By using `NET="Runtime"` on UsingTask declarations, msbuild runs the task always on .NETCoreApp, even on desktop msbuild. Delete two unused projects: - IssueManager (not used in dnceng anymore) - Microsoft.DotNet.Tar (was only necessary for desktop SignTool)
c0c2104 to
35ef0d6
Compare
|
Love this. |
|
SignTool running on framework might have to do with packing/unpacking VSIX's. At least that was the case at some point. For signcheck...IIRC some functionality used to not be supported on core. Maybe some authenticode or VSIX checking? Either way, I think that was resolved. |
By using
NET="Runtime"on UsingTask declarations, msbuild runs the task always on .NETCoreApp, even on desktop msbuild.Delete two unused projects:
Benefits: