Skip to content

Conversation

@askpt
Copy link

@askpt askpt commented Oct 16, 2025

Signed-off-by: André Silva 2493377+askpt@users.noreply.github.com

Summary

Describe your changes here.

Fixes #Issue_Number (if available)


Internal previews

📄 File 🔗 Preview link
docs/community-toolkit/hosting-flagd.md Aspire flagd integration
docs/community-toolkit/overview.md Overview
docs/toc.yml docs/toc

askpt added 3 commits October 16, 2025 12:03
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, a few suggestions, otherwise let's ship it!

We need to have a TOC entry for this as well. Could you please add that to the toc.yml, see: https://github.com/dotnet/docs-aspire/blob/main/docs/toc.yml#L419

askpt and others added 3 commits October 17, 2025 21:21
Co-authored-by: David Pine <david.pine@microsoft.com>
…flagd.md

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
Copy link
Author

askpt commented Oct 17, 2025

This looks good to me, a few suggestions, otherwise let's ship it!

We need to have a TOC entry for this as well. Could you please add that to the toc.yml, see: https://github.com/dotnet/docs-aspire/blob/main/docs/toc.yml#L419

@IEvangelist Thank you so much for the review. I am leaving this PR in draft since this package is not public yet. As soon as we get this out, I will publish it so the documentation will be accessible.

@askpt
Copy link
Author

askpt commented Oct 29, 2025

@IEvangelist I am happy for this to get merged since there are already some packages being published: https://www.nuget.org/packages/CommunityToolkit.Aspire.Hosting.Flagd/

@askpt askpt marked this pull request as ready for review October 29, 2025 22:15
Copilot AI review requested due to automatic review settings October 29, 2025 22:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces documentation for the Aspire Community Toolkit flagd hosting integration, which enables hosting flagd feature flag evaluation containers in Aspire applications.

  • Adds comprehensive documentation for flagd hosting and client integration
  • Updates the Community Toolkit overview to include the new flagd integration
  • Adds the new documentation page to the table of contents

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
docs/community-toolkit/hosting-flagd.md New documentation page detailing flagd hosting and client integration, including configuration, usage examples, and API references
docs/community-toolkit/overview.md Adds flagd to the list of available hosting integrations with links to GitHub and NuGet package
docs/toc.yml Adds table of contents entry for the new flagd documentation page

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants