-
Notifications
You must be signed in to change notification settings - Fork 168
Add flagd Hosting documentation #5300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, a few suggestions, otherwise let's ship it!
We need to have a TOC entry for this as well. Could you please add that to the toc.yml, see: https://github.com/dotnet/docs-aspire/blob/main/docs/toc.yml#L419
Co-authored-by: David Pine <david.pine@microsoft.com>
…flagd.md Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@IEvangelist Thank you so much for the review. I am leaving this PR in draft since this package is not public yet. As soon as we get this out, I will publish it so the documentation will be accessible. |
|
@IEvangelist I am happy for this to get merged since there are already some packages being published: https://www.nuget.org/packages/CommunityToolkit.Aspire.Hosting.Flagd/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces documentation for the Aspire Community Toolkit flagd hosting integration, which enables hosting flagd feature flag evaluation containers in Aspire applications.
- Adds comprehensive documentation for flagd hosting and client integration
- Updates the Community Toolkit overview to include the new flagd integration
- Adds the new documentation page to the table of contents
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/community-toolkit/hosting-flagd.md | New documentation page detailing flagd hosting and client integration, including configuration, usage examples, and API references |
| docs/community-toolkit/overview.md | Adds flagd to the list of available hosting integrations with links to GitHub and NuGet package |
| docs/toc.yml | Adds table of contents entry for the new flagd documentation page |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: André Silva 2493377+askpt@users.noreply.github.com
Summary
Describe your changes here.
Fixes #Issue_Number (if available)
Internal previews