Skip to content

Add replacement property names to VB syntax obsolete attributes #81272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add replacement property names to VB syntax obsolete attributes #81272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
959b234
Initial plan
Copilot Nov 16, 2025
6debb88
Update obsolete messages in VB syntax files to indicate replacement p…
Copilot Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions src/Compilers/VisualBasic/Portable/Syntax/MethodBaseSyntax.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,15 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Syntax
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use SubOrFunctionKeyword instead.", True)>
Public Shadows ReadOnly Property Keyword As SyntaxToken
Get
Return DeclarationKeyword
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithSubOrFunctionKeyword instead.", True)>
Public Shadows Function WithKeyword(keyword As SyntaxToken) As MethodStatementSyntax
Return WithSubOrFunctionKeyword(keyword)
End Function
Expand All @@ -76,15 +76,15 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Syntax
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use SubOrFunctionKeyword instead.", True)>
Public Shadows ReadOnly Property Keyword As SyntaxToken
Get
Return DeclarationKeyword
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithSubOrFunctionKeyword instead.", True)>
Public Shadows Function WithKeyword(keyword As SyntaxToken) As DelegateStatementSyntax
Return WithSubOrFunctionKeyword(keyword)
End Function
Expand All @@ -103,15 +103,15 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Syntax
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use SubOrFunctionKeyword instead.", True)>
Public Shadows ReadOnly Property Keyword As SyntaxToken
Get
Return DeclarationKeyword
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithSubOrFunctionKeyword instead.", True)>
Public Shadows Function WithKeyword(keyword As SyntaxToken) As DeclareStatementSyntax
Return WithSubOrFunctionKeyword(keyword)
End Function
Expand All @@ -131,15 +131,15 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Syntax
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use SubOrFunctionKeyword instead.", True)>
Public Shadows ReadOnly Property Keyword As SyntaxToken
Get
Return DeclarationKeyword
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithSubOrFunctionKeyword instead.", True)>
Public Shadows Function WithKeyword(keyword As SyntaxToken) As LambdaHeaderSyntax
Return WithSubOrFunctionKeyword(keyword)
End Function
Expand All @@ -159,15 +159,15 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Syntax
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use SubKeyword instead.", True)>
Public Shadows ReadOnly Property Keyword As SyntaxToken
Get
Return DeclarationKeyword
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithSubKeyword instead.", True)>
Public Shadows Function WithKeyword(keyword As SyntaxToken) As SubNewStatementSyntax
Return WithSubKeyword(keyword)
End Function
Expand All @@ -187,15 +187,15 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Syntax
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use EventKeyword instead.", True)>
Public Shadows ReadOnly Property Keyword As SyntaxToken
Get
Return DeclarationKeyword
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithEventKeyword instead.", True)>
Public Shadows Function WithKeyword(keyword As SyntaxToken) As EventStatementSyntax
Return WithEventKeyword(keyword)
End Function
Expand All @@ -215,15 +215,15 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Syntax
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use PropertyKeyword instead.", True)>
Public Shadows ReadOnly Property Keyword As SyntaxToken
Get
Return DeclarationKeyword
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithPropertyKeyword instead.", True)>
Public Shadows Function WithKeyword(keyword As SyntaxToken) As PropertyStatementSyntax
Return WithPropertyKeyword(keyword)
End Function
Expand All @@ -243,15 +243,15 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Syntax
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use OperatorKeyword instead.", True)>
Public Shadows ReadOnly Property Keyword As SyntaxToken
Get
Return DeclarationKeyword
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithOperatorKeyword instead.", True)>
Public Shadows Function WithKeyword(keyword As SyntaxToken) As OperatorStatementSyntax
Return WithOperatorKeyword(keyword)
End Function
Expand All @@ -271,15 +271,15 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Syntax
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use AccessorKeyword instead.", True)>
Public Shadows ReadOnly Property Keyword As SyntaxToken
Get
Return DeclarationKeyword
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithAccessorKeyword instead.", True)>
Public Shadows Function WithKeyword(keyword As SyntaxToken) As AccessorStatementSyntax
Return WithAccessorKeyword(keyword)
End Function
Expand Down
24 changes: 12 additions & 12 deletions src/Compilers/VisualBasic/Portable/Syntax/MethodBlockBaseSyntax.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,29 +138,29 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Syntax
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use SubNewStatement instead.", True)>
Public Shadows ReadOnly Property Begin As SubNewStatementSyntax
Get
Return SubNewStatement
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use EndSubStatement instead.", True)>
Public Shadows ReadOnly Property [End] As EndBlockStatementSyntax
Get
Return EndSubStatement
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithSubNewStatement instead.", True)>
Public Shadows Function WithBegin(begin As SubNewStatementSyntax) As ConstructorBlockSyntax
Return WithSubNewStatement(begin)
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithEndSubStatement instead.", True)>
Public Shadows Function WithEnd([end] As EndBlockStatementSyntax) As ConstructorBlockSyntax
Return WithEndSubStatement([end])
End Function
Expand Down Expand Up @@ -190,29 +190,29 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Syntax
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use SubOrFunctionStatement instead.", True)>
Public Shadows ReadOnly Property Begin As MethodStatementSyntax
Get
Return SubOrFunctionStatement
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use EndSubOrFunctionStatement instead.", True)>
Public Shadows ReadOnly Property [End] As EndBlockStatementSyntax
Get
Return EndSubOrFunctionStatement
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithSubOrFunctionStatement instead.", True)>
Public Shadows Function WithBegin(begin As MethodStatementSyntax) As MethodBlockSyntax
Return WithSubOrFunctionStatement(begin)
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithEndSubOrFunctionStatement instead.", True)>
Public Shadows Function WithEnd([end] As EndBlockStatementSyntax) As MethodBlockSyntax
Return WithEndSubOrFunctionStatement([end])
End Function
Expand Down Expand Up @@ -242,29 +242,29 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Syntax
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use OperatorStatement instead.", True)>
Public Shadows ReadOnly Property Begin As OperatorStatementSyntax
Get
Return OperatorStatement
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use EndOperatorStatement instead.", True)>
Public Shadows ReadOnly Property [End] As EndBlockStatementSyntax
Get
Return EndOperatorStatement
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithOperatorStatement instead.", True)>
Public Shadows Function WithBegin(begin As OperatorStatementSyntax) As OperatorBlockSyntax
Return WithOperatorStatement(begin)
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithEndOperatorStatement instead.", True)>
Public Shadows Function WithEnd([end] As EndBlockStatementSyntax) As OperatorBlockSyntax
Return WithEndOperatorStatement([end])
End Function
Expand Down
32 changes: 16 additions & 16 deletions src/Compilers/VisualBasic/Portable/Syntax/TypeBlockSyntax.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,29 +86,29 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Syntax
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use ClassStatement instead.", True)>
Public Shadows ReadOnly Property Begin As ClassStatementSyntax
Get
Return ClassStatement
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use EndClassStatement instead.", True)>
Public Shadows ReadOnly Property [End] As EndBlockStatementSyntax
Get
Return EndClassStatement
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithClassStatement instead.", True)>
Public Shadows Function WithBegin(begin As ClassStatementSyntax) As ClassBlockSyntax
Return WithClassStatement(begin)
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithEndClassStatement instead.", True)>
Public Shadows Function WithEnd([end] As EndBlockStatementSyntax) As ClassBlockSyntax
Return WithEndClassStatement([end])
End Function
Expand Down Expand Up @@ -138,29 +138,29 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Syntax
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use StructureStatement instead.", True)>
Public Shadows ReadOnly Property Begin As StructureStatementSyntax
Get
Return StructureStatement
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use EndStructureStatement instead.", True)>
Public Shadows ReadOnly Property [End] As EndBlockStatementSyntax
Get
Return EndStructureStatement
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithStructureStatement instead.", True)>
Public Shadows Function WithBegin(begin As StructureStatementSyntax) As StructureBlockSyntax
Return WithStructureStatement(begin)
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithEndStructureStatement instead.", True)>
Public Shadows Function WithEnd([end] As EndBlockStatementSyntax) As StructureBlockSyntax
Return WithEndStructureStatement([end])
End Function
Expand Down Expand Up @@ -190,29 +190,29 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Syntax
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use InterfaceStatement instead.", True)>
Public Shadows ReadOnly Property Begin As InterfaceStatementSyntax
Get
Return InterfaceStatement
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use EndInterfaceStatement instead.", True)>
Public Shadows ReadOnly Property [End] As EndBlockStatementSyntax
Get
Return EndInterfaceStatement
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithInterfaceStatement instead.", True)>
Public Shadows Function WithBegin(begin As InterfaceStatementSyntax) As InterfaceBlockSyntax
Return WithInterfaceStatement(begin)
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithEndInterfaceStatement instead.", True)>
Public Shadows Function WithEnd([end] As EndBlockStatementSyntax) As InterfaceBlockSyntax
Return WithEndInterfaceStatement([end])
End Function
Expand Down Expand Up @@ -242,29 +242,29 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Syntax
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use ModuleStatement instead.", True)>
Public Shadows ReadOnly Property Begin As ModuleStatementSyntax
Get
Return ModuleStatement
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use EndModuleStatement instead.", True)>
Public Shadows ReadOnly Property [End] As EndBlockStatementSyntax
Get
Return EndModuleStatement
End Get
End Property

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithModuleStatement instead.", True)>
Public Shadows Function WithBegin(begin As ModuleStatementSyntax) As ModuleBlockSyntax
Return WithModuleStatement(begin)
End Function

<EditorBrowsable(EditorBrowsableState.Never)>
<Obsolete("This member is obsolete.", True)>
<Obsolete("This member is obsolete. Use WithEndModuleStatement instead.", True)>
Public Shadows Function WithEnd([end] As EndBlockStatementSyntax) As ModuleBlockSyntax
Return WithEndModuleStatement([end])
End Function
Expand Down
Loading
Loading