Improve error recovery in parenthesized constructs #81279
Conversation
|
@dotnet/roslyn-compiler this is ready for review. |
src/Compilers/CSharp/Test/Syntax/Parsing/ExpressionParsingTests.cs
Outdated
Show resolved
Hide resolved
| public void InProgressMultipleExpressionsInIfStatement2() | ||
| { | ||
| UsingTree(""" | ||
| if (1 2) |
There was a problem hiding this comment.
6953506. Note: recovery isn't great. But that's ok.
- it's no worse than before
- this is not an intermediary state. it woudl require deleting multiple discontinuous tokens to get here.
jcouv
left a comment
jcouv
left a comment
There was a problem hiding this comment.
Done with review pass (commit 7)
|
Maybe just "operator expected"? |
Meh, I guess. I'm not sure what to expect. I just know that the second expression is unexpected. |
|
I can just say |
There was a problem hiding this comment.
Can we add some tests for tuple expressions? And deconstruction assignments?
There was a problem hiding this comment.
Added tests. Tuples retain the same poor behavior as before.
I'm not changing this as tuple expression parsing is more complex due to allowing declaration, and being comma separable not just having a close paren that follows but also a comma. Fixing would be move involved and I'd prefer to keep this pr simple and safe :).
3 participants
Fixes #16595
Fixes #4009