make copilot setup run on 8 cores not 2 #116169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Copilot setup workflow to use a higher-capacity runner, reducing setup time.
- Swaps the default
ubuntu-latestrunner for a custom8-core-ubuntu-latestrunner. - Verifies test builds and reduces setup duration from 26 min to 17 min.
danmoseley
added
area-Infrastructure
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
stephentoub
approved these changes
May 31, 2025
Member
Author
|
/ba-g not in build |
Member
Author
|
my concern may have been correct -- a test copilot run appears to be unable to get a runner. If that's the case, this will need reverting,
@Chuxel any guidance here, do you believe it ought to be possible to use better runners for hte setup steps? |
Member
Author
|
following up on the above, was resolved by removing the branch-locking of the runner group. its still locked to this repo |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this runner group at the org level locked down to main (and test branch) in this repo. (You have to lock to ref(s))
I verified the test runner is found and used when I kick the action manually against this PR branch:
https://github.com/dotnet/runtime/actions/workflows/copilot-setup-steps.yml
It cuts down the setup time from 26 min to 17 min. (We could add more cores too)
Now putting it in main, the question is, will copilot use it, as it creates its own PR branch which it builds (not main). I guess if we merge this, we will find out.