Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 13, 2025

Fixes compilation error introduced by Roslyn 4.14.0's stricter type checking for array-to-span conversions.

main PR: #121343

Description

Roslyn 4.14.0 no longer allows implicit conversion from string[] to Span<string?>. Fixed by explicitly converting arrays to spans in HttpHeaders.GetStoreValuesIntoStringArray:

// Before
ReadStoreValues<object?>(values, info.ParsedAndInvalidValues, descriptor.Parser, ref currentIndex);

// After  
ReadStoreValues<object?>(values.AsSpan(), info.ParsedAndInvalidValues, descriptor.Parser, ref currentIndex);

Customer Impact

Blocks servicing release builds. No runtime behavior change.

Regression

No - compiler enforcement tightening from dependency update.

Testing

Verified compilation fix. No functional changes to test.

Risk

Minimal. Surgical two-line change converts array to span where method signature already required it. Identical pattern to fixes in #121414 and BigInteger.cs (46bb931).


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com>
Copilot AI changed the title [WIP] Update dependencies from dotnet/roslyn Fix CS8620 compiler error in HttpHeaders after Roslyn 4.14.0 update Nov 13, 2025
Copilot AI requested a review from sbomer November 13, 2025 22:51
@sbomer sbomer marked this pull request as ready for review November 14, 2025 17:26
@sbomer sbomer merged commit 6e2757c into darc-release/9.0-staging-4da6a74f-9a77-4837-ae86-0b0dfcd7a5bd Nov 14, 2025
9 of 11 checks passed
@jkotas jkotas deleted the copilot/sub-pr-121343 branch November 15, 2025 19:14
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants