Ensure that --nologo adheres to DOTNET_NOLOGO if present
#51462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2025
baronfel
force-pushed
the
consistently-handle-dotnet-nologo
branch
from
d1db235 to
e08348f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the third bullet described in #12195 (comment) -
users were surprised that
dotnet msbuilddidn't respectDOTNET_NOLOGO. This is somewhat of a grey area sincedotnet msbuilddoesn't do much customization at all anyway, but this seemed harmless enough to take a crack at it.Along the way I encoded the respecting of the env var into a shared Option implementation for all the existing commands to adhere to.