Installer: Get channels from release.json, and other improvements

[dsplaisted]

• Implement GetSupportedChannels via release APIs and add test coverage
• Remove unused mock classes
• Fix issue where SDK path from global.json wasn't being resolved relative to the global.json file
• Fix some NativeAOT issues

There were some NativeAOT issues with Microsoft.DotNet.NativeWrapper. I've fixed the warnings but I'm not sure how loading the hostfxr libraries is supposed to work in a NativeAOT app. The code expects to find hostfxr.dll in the app base directory. So we may need some more changes there.

There are also trim warnings from Spectre.Console which cause the NatievAOT publish to fail. However, I haven't yet figured out what those warnings actually are.

We should hook up a publish of dnup to the pipelines so that we are validating we can actually produce a NativeAOT app.

[baronfel]

What do we need hostfxr for on this pathway? We will not have access to it at all in AOT mode IIRC, we may need to use something like the library @ericstj pointed me at earlier today to get a managed equivalent to what hostfxr provides.

[dsplaisted]

What do we need hostfxr for on this pathway? We will not have access to it at all in AOT mode IIRC, we may need to use something like the library @ericstj pointed me at earlier today to get a managed equivalent to what hostfxr provides.

Right now we are using it to validate that an SDK or runtime has installed correctly:

sdk/src/Installer/dnup/ArchiveInstallationValidator.cs

Lines 74 to 106 in 11265f1

	private bool ValidateWithHostFxr(string installRoot, ReleaseVersion resolvedVersion, InstallComponent component)
	{
	try
	{
	ConfigureHostFxrResolution(installRoot);
	var bundleProvider = new NETBundlesNativeWrapper();
	NetEnvironmentInfo environmentInfo = bundleProvider.GetDotnetEnvironmentInfo(installRoot);
	if (component == InstallComponent.SDK)
	{
	string expectedPath = Path.Combine(installRoot, "sdk", resolvedVersion.ToString());
	return environmentInfo.SdkInfo.Any(sdk =>
	string.Equals(sdk.Version.ToString(), resolvedVersion.ToString(), StringComparison.OrdinalIgnoreCase) &&
	DnupUtilities.PathsEqual(sdk.Path, expectedPath));
	}
	if (!RuntimeMonikerByComponent.TryGetValue(component, out string? runtimeMoniker))
	{
	return false;
	}
	string expectedRuntimePath = Path.Combine(installRoot, "shared", runtimeMoniker, resolvedVersion.ToString());
	return environmentInfo.RuntimeInfo.Any(runtime =>
	string.Equals(runtime.Name, runtimeMoniker, StringComparison.OrdinalIgnoreCase) &&
	string.Equals(runtime.Version.ToString(), resolvedVersion.ToString(), StringComparison.OrdinalIgnoreCase) &&
	DnupUtilities.PathsEqual(runtime.Path, expectedRuntimePath));
	}
	catch
	{
	return false;
	}
	}

I think we were thinking about also using it to find what versions are installed.

[baronfel]

Here's the library I mentioned: https://github.com/ericstj/dotnetlocator - it's not production but seems to be the way we're starting to think about this kind of shared resource.

I think its expected surface area would be able to satisfy what hostfxr is being used for in the code you linked?

[nagilson]

Thanks, good call out on the AOT portion and the SDK tests not running dnup tests. I've left a few comments.

[nagilson]

I think we should keep this in a data structure of special keyword channels we support.

[nagilson]

For my understanding, why did we use net8.0 here?

[dsplaisted]

When I didn't have the condition it gave me an error saying the property wasn't supported for .NET Framework, and the error suggested this condition. I think the property is maybe supported on .NET 6 and higher.

[nagilson]

👍