Fix NRE when running sln remove#53200
Open
andbrl wants to merge 1 commit intodotnet:release/10.0.3xxfrom
Open
Conversation
Running `dotnet sln remove foo` with a project name without including the extension caused an NRE to be thrown. This is because `DisplayName` is null. Using `ActualDisplayName` instead fixes this.
edvilme
reviewed
Feb 28, 2026
| @@ -84,7 +76,7 @@ private static async Task RemoveProjectsAsync(string solutionFileFullPath, IEnum | |||
| // If the project is not found, try to find it by name without extension | |||
| if (project is null && !Path.HasExtension(projectPath)) | |||
| { | |||
| var projectsMatchByName = solution.SolutionProjects.Where(p => Path.GetFileNameWithoutExtension(p.DisplayName).Equals(projectPath)); | |||
| var projectsMatchByName = solution.SolutionProjects.Where(p => p.ActualDisplayName.Equals(projectPath)); | |||
Contributor
There was a problem hiding this comment.
Good catch! p.DisplayName could return null
This was referenced Mar 1, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋 , this PR fixes an NRE when running dotnet sln remove with a project name that doesn't exist (without extension) in the solution.
The property DisplayName is null, causing
Path.GetExtensionWithoutFileNameto return null leading to an NRE. So the command outputs the following:"Object reference not set to an instance of an object."
Changing it to use
ActualDisplayNamefixes this and we get:"Project 'foo' could not be found in the solution."