Open
Conversation
added 3 commits
January 22, 2017 17:19
* update jshint & make .jshintrc more contemporary * breakout superfluous setmetadata fn
* feature: interpolation * added interpolation test
Author
That sucked.. can we test against node 6 or do we need node 5 compat ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added interpolation of values so plugin calls can specify
metadatavalues like{ cover: 'images/{title}.jpg' }.IDK if this is poor form, but I switched from minimatch to multimatch as it seems like that's become the defacto standard for metalsmith plugins. Doing that meant that it was sensible to fold the
setmetadatafn back into the primary fn. So it looks like I've taken a knife to the original plugin but that wasn't really my intention.