-
Notifications
You must be signed in to change notification settings - Fork 16
This PR adds the DQ_JointType class and setter and getter methods for the DQ_SerialManipulator class. #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…et,get}_joint_{type, types} methods.
…types to accept eigen vectors.
…ing the paper in which the class is based on.
…ves the compilation on Ubuntu.
mmmarinho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easy one for you @juanjqo
| * @brief ToString converts the DQ_JointType to string. | ||
| * @return A string that corresponds to the joint type. | ||
| */ | ||
| std::string ToString() const { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method name ‘ToString’ is not compliant. I think we have something similar in ‘DQ’, could you please refer to that one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmmarinho fixed! =)
…d to to_string in the class DQ_JointType and updated the class DQ_SerialManipulator to comply with this modification.
mmmarinho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepted pending dqrobotics/cpp-examples#21
Hi @dqrobotics/developers,
This PR adds the DQ_JointType class and setter and getter methods for the
DQ_SerialManipulatorclass. All of them are already available in the Matlab version of theDQ Robotics. The class follows the pattern design of theDQ_ParameterDHclass (added in #69), which prioritizes the language compatibility with the MATLAB implementation.I proposed a test example in dqrobotics/cpp-examples#21.
Usage
Creating a robot
Setting unsupported joints
libc++abi: terminating due to uncaught exception of type std::runtime_error: Unsupported joint types. Use valid joint types: DQ_JointType::REVOLUTE, DQ_JointType::PRISMATIC.Kind regards,
Juancho