fix(tiering): Limit offload budget by time #5970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
Oct 28, 2025
src/server/tiered_storage.cc
Outdated
| auto disk_stats = op_manager_->GetStats().disk_stats; | ||
| if (disk_stats.allocated_bytes + kMaxIterations / 2 * tiering::kPageSize > | ||
| disk_stats.max_file_size) | ||
| if (disk_stats.allocated_bytes + 50 * tiering::kPageSize > disk_stats.max_file_size) |
Collaborator
There was a problem hiding this comment.
what's a 50? add a constant with a meaningful name
romange
approved these changes
Oct 29, 2025
abhijat
pushed a commit
that referenced
this pull request
Nov 3, 2025
Signed-off-by: Abhijat Malviya <abhijat@dragonflydb.io>
abhijat
pushed a commit
that referenced
this pull request
Nov 3, 2025
Signed-off-by: Abhijat Malviya <abhijat@dragonflydb.io>
abhijat
pushed a commit
that referenced
this pull request
Nov 3, 2025
Signed-off-by: Abhijat Malviya <abhijat@dragonflydb.io>
abhijat
pushed a commit
that referenced
this pull request
Nov 3, 2025
Signed-off-by: Abhijat Malviya <abhijat@dragonflydb.io>
abhijat
pushed a commit
that referenced
this pull request
Nov 3, 2025
Signed-off-by: Abhijat Malviya <abhijat@dragonflydb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stopping by max iterations was a very simple heuristic that I put a long time ago - it obviously doesn't work. It decimates p99 for to put it mildly
I dream of making heartbeat use it's background possibilities. The issue with those yields is that our offloading speed is now much much slower... 🤔