skipping empty lines in header #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the pull request! I didn't realize other tools were adding empty lines. Yeah, it's not part of the PLY spec, but it's minor enough that I think we can allow it. |
Owner
|
Thanks for the change. This has been merged into master, and it will be included in the next point release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great work on the plyfile library! We use the point cloud reader in multiple projects to load point clouds with additional scalar fields. While scalar fields are part of the PLY specification and supported by tools like CloudCompare, not many Python packages handle them well.
One prerequisite, of course, is being able to load the point cloud itself. Unfortunately, some companies produce PLY headers that contain empty lines. This isn’t mentioned in the PLY specification, but since tools like Open3D and CloudCompare tolerate it, they get away with it.
We can always strip the empty lines before loading, but it seems like a relatively small adjustment to support this directly in the library. It might be worth considering?