Skip to content

Expand TLD validation size to 63 for long gTLD.#7

Merged
dresende merged 2 commits intodresende:masterfrom
kevpie:long_email_tld
Jan 4, 2017
Merged

Expand TLD validation size to 63 for long gTLD.#7
dresende merged 2 commits intodresende:masterfrom
kevpie:long_email_tld

Conversation

@kevpie
Copy link
Contributor

@kevpie kevpie commented Jan 3, 2017

Newer live TLD's are already at 24 char and could grow all the way to 63 char.

@kevpie
Copy link
Contributor Author

kevpie commented Jan 3, 2017

Hello @dresende,
This solves an issue that came up with using one of the newer TLD's. I had a user trying to register an email like user@some.college from the college TLD. I am using 3.2.0 of node-orm2 and hope to see this work it's way through soon.

Anything you would like changed?

Thank you.

@dresende
Copy link
Owner

dresende commented Jan 4, 2017

LGTM :)

@dresende dresende merged commit 6358e2e into dresende:master Jan 4, 2017
@dresende
Copy link
Owner

dresende commented Jan 4, 2017

dresende/node-orm2#763

@dxg
Copy link
Collaborator

dxg commented Jan 6, 2017

Released in version 3.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants