Skip to content

Fix for incorrect argument handling in delete accessor of Many association #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dresende merged 2 commits into from
Sep 13, 2013
Merged

Fix for incorrect argument handling in delete accessor of Many association #320

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bbac56
Fix for removing array of to-many associations with a single call to …
kvanwagenen Sep 2, 2013
d2c1ff5
Replaced argument handling of to-many remove handler with more robust…
kvanwagenen Sep 2, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions lib/Associations/Many.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,22 @@ function extendInstance(Model, Instance, Driver, association, opts, createInstan
});
Object.defineProperty(Instance, association.delAccessor, {
value: function () {
var Associations = Array.prototype.slice.apply(arguments);
var cb = (typeof Associations[Associations.length - 1] == "function" ? Associations.pop() : noOperation);
var Associations = [];
var cb = noOperation;
for (var i = 0; i < arguments.length; i++) {
switch (typeof arguments[i]) {
case "function":
cb = arguments[i];
break;
case "object":
if (Array.isArray(arguments[i])) {
Associations = Associations.concat(arguments[i]);
} else if (arguments[i].isInstance) {
Associations.push(arguments[i]);
}
break;
}
}
var conditions = {};
var run = function () {
if (Driver.hasMany) {
Expand Down