Fixed Rector running with --clear-cache in CI.
#2223
Conversation
WalkthroughThis change removes the Changes
Sequence Diagram(s)(omitted — changes are small and do not introduce multi-component control-flow requiring visualization) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.vortex/installer/src/Prompts/Handlers/Tools.php (1)
162-162: Critical typo: 'goups' should be 'groups'.This typo will cause a runtime error when attempting to retrieve group definitions, as the key
'goups'does not exist in the map.🐛 Proposed fix
- $config = static::getToolDefinitions('goups')[$name]; + $config = static::getToolDefinitions('groups')[$name];
🤖 Fix all issues with AI agents
In @.vortex/installer/src/Prompts/Handlers/Tools.php:
- Around line 235-239: The 'ahoy' array in Tools.php is missing a trailing comma
and should include the three expanded Rector command variants to match CI
changes; update the 'ahoy' => [...] entry (the array assigned to the 'ahoy' key)
by adding a trailing comma after the last string element and confirm the array
contains the three entries 'ahoy cli vendor/bin/rector --clear-cache --dry-run',
'ahoy cli vendor/bin/rector --dry-run', and 'ahoy cli vendor/bin/rector' so the
CLI/CI expansions remain consistent.
📜 Review details
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (20)
.vortex/installer/tests/Fixtures/handler_process/_baseline/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/ciprovider_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deploy_types_all_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deploy_types_none_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deps_updates_provider_ci_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/timezone_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_lint/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_lint/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_lint_circleci/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpcs_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpmd/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpmd_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpstan/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpstan_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_rector/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_none/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_none/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (3)
.circleci/config.yml.github/workflows/build-test-deploy.yml.vortex/installer/src/Prompts/Handlers/Tools.php
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-11-24T21:29:10.896Z
Learnt from: CR
Repo: drevops/vortex PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T21:29:10.896Z
Learning: Use 'ahoy' command prefix for all local development commands instead of running commands directly
Applied to files:
.vortex/installer/src/Prompts/Handlers/Tools.php
📚 Learning: 2025-09-13T04:14:41.765Z
Learnt from: AlexSkrypnyk
Repo: drevops/vortex PR: 2011
File: .vortex/tests/phpunit/Traits/Steps/StepAhoyTrait.php:20-23
Timestamp: 2025-09-13T04:14:41.765Z
Learning: In .vortex/tests/phpunit PHPUnit tests using cmd/cmdFail helpers, patterns in the expected output arrays support '*' markers for positive assertions (text must be present) and '!' markers for negative assertions (text must NOT be present). The '*' markers are NOT literal text matches but rather indicate expected presence.
Applied to files:
.vortex/installer/src/Prompts/Handlers/Tools.php
🪛 GitHub Actions: Vortex - Test installer
.vortex/installer/src/Prompts/Handlers/Tools.php
[warning] 238-238: A comma should follow the last multiline array item. Found: 'ahoy cli vendor/bin/rector' (Drupal.Arrays.Array.CommaLastItem)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: build (0)
- GitHub Check: build (1)
- GitHub Check: vortex-test-workflow (4)
- GitHub Check: vortex-test-workflow (3)
- GitHub Check: vortex-test-workflow (2)
- GitHub Check: vortex-test-workflow (1)
- GitHub Check: vortex-test-workflow (0)
🔇 Additional comments (2)
.circleci/config.yml (1)
314-314: LGTM! Rector command updated correctly.The removal of
--clear-cachealigns with the PR objective and maintains the--dry-runflag for linting purposes in CI..github/workflows/build-test-deploy.yml (1)
303-303: LGTM! Consistent with CircleCI configuration.The removal of
--clear-cacheis consistent with the corresponding change in.circleci/config.ymland aligns with the PR objective.
This comment has been minimized.
This comment has been minimized.
|
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2223 +/- ##
===========================================
- Coverage 99.37% 76.22% -23.15%
===========================================
Files 7 105 +98
Lines 159 5687 +5528
Branches 44 0 -44
===========================================
+ Hits 158 4335 +4177
- Misses 1 1352 +1351 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AlexSkrypnyk
force-pushed
the
feature/fix-rector-in-ci
branch
from
35eea19 to
ba4a4bb
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.vortex/installer/src/Prompts/Handlers/Tools.php (1)
162-162: Fix typo causing runtime error.The method call uses
'goups'instead of'groups', which will cause a fatal error when attempting to access an undefined array key during group processing.🐛 Proposed fix
- $config = static::getToolDefinitions('goups')[$name]; + $config = static::getToolDefinitions('groups')[$name];
🤖 Fix all issues with AI agents
In @README.md:
- Line 124: Remove the redundant phrase "over time" from the sentence containing
"a practical example of how the template evolves over time" so it reads "a
practical example of how the template evolves"; update the sentence text
accordingly in README.md where that exact string appears.
- Line 72: Wrap the bare URL on the line containing "found at
https://vortex-docs.netlify.app/install" in angle brackets so it becomes
<https://vortex-docs.netlify.app/install> to comply with Markdown style and
ensure proper link rendering.
📜 Review details
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (20)
.vortex/installer/tests/Fixtures/handler_process/_baseline/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/ciprovider_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deploy_types_all_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deploy_types_none_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deps_updates_provider_ci_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/timezone_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_lint/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_lint/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_lint_circleci/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpcs_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpmd/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpmd_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpstan/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpstan_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_rector/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_none/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_none/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (4)
.circleci/config.yml.github/workflows/build-test-deploy.yml.vortex/installer/src/Prompts/Handlers/Tools.phpREADME.md
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-13T04:14:41.765Z
Learnt from: AlexSkrypnyk
Repo: drevops/vortex PR: 2011
File: .vortex/tests/phpunit/Traits/Steps/StepAhoyTrait.php:20-23
Timestamp: 2025-09-13T04:14:41.765Z
Learning: In .vortex/tests/phpunit PHPUnit tests using cmd/cmdFail helpers, patterns in the expected output arrays support '*' markers for positive assertions (text must be present) and '!' markers for negative assertions (text must NOT be present). The '*' markers are NOT literal text matches but rather indicate expected presence.
Applied to files:
.vortex/installer/src/Prompts/Handlers/Tools.php
🪛 LanguageTool
README.md
[style] ~124-~124: This phrase is redundant. Consider writing “evolves”.
Context: ...a practical example of how the template evolves over time. ## Support We provide paid support f...
(EVOLVE_OVER_TIME)
🪛 markdownlint-cli2 (0.18.1)
README.md
72-72: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
- GitHub Check: build (1)
- GitHub Check: build (0)
- GitHub Check: vortex-test-workflow (3)
- GitHub Check: vortex-test-workflow (0)
- GitHub Check: vortex-test-workflow (4)
- GitHub Check: vortex-test-workflow (1)
- GitHub Check: vortex-test-workflow (2)
- GitHub Check: vortex-test-common
- GitHub Check: vortex-test-installer (8.4)
- GitHub Check: vortex-test-installer (8.2)
- GitHub Check: vortex-test-installer (8.3)
- GitHub Check: main
🔇 Additional comments (3)
.github/workflows/build-test-deploy.yml (1)
303-303: LGTM! Rector cache flag removed as intended.The change removes the
--clear-cacheflag while preserving the--dry-runbehavior for CI linting. This aligns with the PR objective to fix Rector running in CI..circleci/config.yml (1)
314-314: LGTM! Consistent cache flag removal across CI platforms.The change mirrors the GitHub Actions workflow update, removing
--clear-cachewhile maintaining the dry-run behavior and error handling fallback..vortex/installer/src/Prompts/Handlers/Tools.php (1)
235-239: LGTM! Rector command variants properly expanded.The Ahoy command definitions now include three variants: clear-cache with dry-run, dry-run only, and full execution. This properly supports the removal of
--clear-cachefrom CI while maintaining the ability to clear cache when needed locally.
|
|
||
| The latest development version of the installer from `develop` branch can be found at https://vortex-docs.netlify.app/install | ||
| The latest development version of the installer from `develop` branch can be | ||
| found at https://vortex-docs.netlify.app/install |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Address markdown style: wrap bare URL.
The bare URL should be wrapped in angle brackets for proper markdown formatting.
📝 Proposed fix
-found at https://vortex-docs.netlify.app/install
+found at <https://vortex-docs.netlify.app/install>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| found at https://vortex-docs.netlify.app/install | |
| found at <https://vortex-docs.netlify.app/install> |
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
72-72: Bare URL used
(MD034, no-bare-urls)
🤖 Prompt for AI Agents
In @README.md at line 72, Wrap the bare URL on the line containing "found at
https://vortex-docs.netlify.app/install" in angle brackets so it becomes
<https://vortex-docs.netlify.app/install> to comply with Markdown style and
ensure proper link rendering.
|
|
||
| Use this project as a reference for structuring your own Vortex-based site or as a practical example of how the template evolves over time. | ||
| Use this project as a reference for structuring your own Vortex-based site or as | ||
| a practical example of how the template evolves over time. |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Remove redundant phrase.
The phrase "evolves over time" is redundant; "evolves" alone conveys the same meaning.
📝 Proposed fix
-a practical example of how the template evolves over time.
+a practical example of how the template evolves.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| a practical example of how the template evolves over time. | |
| a practical example of how the template evolves. |
🧰 Tools
🪛 LanguageTool
[style] ~124-~124: This phrase is redundant. Consider writing “evolves”.
Context: ...a practical example of how the template evolves over time. ## Support We provide paid support f...
(EVOLVE_OVER_TIME)
🤖 Prompt for AI Agents
In @README.md at line 124, Remove the redundant phrase "over time" from the
sentence containing "a practical example of how the template evolves over time"
so it reads "a practical example of how the template evolves"; update the
sentence text accordingly in README.md where that exact string appears.
|
|
|
|
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.