Skip to content

Fix: Use Xcode diagnostic format patterns to avoid false positive error counts #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drewster99 merged 1 commit into from
Jan 9, 2026
Merged

Fix: Use Xcode diagnostic format patterns to avoid false positive error counts #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions xcode_mcp_server/utils/xcresult.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,9 +321,12 @@ def extract_build_errors_and_warnings(build_log: str,
"""
Extract and format errors and warnings from a build log using regex pattern matching.

Uses word-boundary regex patterns (\\berror\\s*: and \\bwarning\\s*:) to match compiler
errors and warnings while avoiding false positives from phrases like "error-free" or
"no errors detected".
Uses Xcode diagnostic format patterns to match compiler errors and warnings:
- file:line:column: error: (typical compiler output)
- ^error: at start of line (standalone errors like linker errors)

This avoids false positives from Objective-C method signatures like error:(NSError**)error
and code snippets in warning messages.

Writes the complete unfiltered build log to /tmp/xcode-mcp-server/logs/build-{hash}.txt
for full analysis.
Expand Down Expand Up @@ -381,10 +384,12 @@ def extract_build_errors_and_warnings(build_log: str,
error_lines = []
warning_lines = []

# Pattern for compiler errors/warnings: matches "error:" or "warning:" at word boundaries
# This avoids false positives from phrases like "error-free" or "no errors"
error_pattern = re.compile(r'\berror\s*:', re.IGNORECASE)
warning_pattern = re.compile(r'\bwarning\s*:', re.IGNORECASE)
# Pattern for compiler errors/warnings in Xcode diagnostic format:
# - file:line:column: error: message (typical compiler output)
# - ^error: at start of line (standalone errors like linker errors)
# This avoids false positives from Objective-C method signatures like "error:(NSError**)error"
error_pattern = re.compile(r'(:\d+:\d+: error:)|(^error\s*:)', re.IGNORECASE | re.MULTILINE)
warning_pattern = re.compile(r'(:\d+:\d+: warning:)|(^warning\s*:)', re.IGNORECASE | re.MULTILINE)

# Single iteration through output lines to extract errors/warnings
for line in output_lines:
Expand Down