Skip to content

#146 - Fixed UNSAFE_componentWillReceiveProps #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
im28 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#146 - Fixed UNSAFE_componentWillReceiveProps #154

im28 wants to merge 1 commit into from

Conversation

@im28
Copy link

@im28 im28 commented Feb 25, 2022 •
edited
Loading

Fixed UNSAFE_componentWillReceiveProps by replacing with getDerivedStateFromProps

@dreyescat
Copy link
Owner

dreyescat commented Feb 27, 2022

Thanks @im28!

I have only checked the examples in index.html and I don't think it is working 😕. Did you try that at least those examples are working as expected?

BTW, you don't need to commit the generated files under the lib directory. They are automatically generated when a new version is released.

@rimzzlabs
Copy link

rimzzlabs commented Sep 7, 2022

Hello, just want to know is it already fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@im28 @dreyescat @rimzzlabs