Closed
Conversation
...because it doesn't allow you to use drone-wall in mesos environments
Contributor
|
None of this much applies to the current release of the wall, feel free to open a new PR if you are having a similar issue with the latest version. |
Author
|
I'm glad this doesn't apply to the latest version! I'll check it next week. I think this PR could be merged into the v2 branch anyway. Even if the branch is not going to be maintained anymore. Docker is not yet supported in v3 and I don't know if this latest version supports drone v0.3 as v2 did... what do you think? |
Contributor
|
Sure, I've gone ahead and made a branch for the v2 version, since it's true that v3 doesn't support drone v0.3. Go ahead and re-open a pull on that branch. Mention |
Author
|
done! see #34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...because it doesn't allow you to use drone-wall in mesos environments