Changes the name of generated rules to be valid in more cases#20
Open
mattnathan wants to merge 1 commit intodropbox:masterfrom
Open
Changes the name of generated rules to be valid in more cases#20mattnathan wants to merge 1 commit intodropbox:masterfrom
mattnathan wants to merge 1 commit intodropbox:masterfrom
Conversation
In addition if you are outputting the generated files into a folder that looks like the npm package name then omit the prefix part to simplify importing in bazel. For example if you npm package is `@vue/cli` and your output dir is `~/myrepo/vue/cli` then the generated rule name will now be `cli` which will allow importing like `//myrepo/vue/cli`. If the output dir doesn't match the package name then any `/` will be replaced by '_' in the rule name.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition if you are outputting the generated files into a folder that
looks like the npm package name then omit the prefix part to simplify
importing in bazel.
For example if you npm package is
@vue/cliand your output dir is~/myrepo/vue/clithen the generated rule name will now becliwhichwill allow importing like
//myrepo/vue/cli. If the output dir doesn'tmatch the package name then any
/will be replaced by '_' in the rulename.