Skip to content

Conversation

@leonhma
Copy link
Contributor

@leonhma leonhma commented Jul 11, 2021

This is again some changes to the docs. Can be seen on my forked repo leonhma/infidel-sensor. I also deleted the gh-pages workflow, in favor of hosting the docs on rtd. This is also linked in the forked repo and the pullrequest preview as in #44 can be seen in leonhma#2 (click on 'show all checks' and then 'details'). To add this feature either an existing maintainer has to link to rtd and set stuff up, or i can do it and will have to be made maintainer.

@drspangle
Copy link
Owner

@leonhma I don't mind making you a maintainer.

@leonhma
Copy link
Contributor Author

leonhma commented Jul 12, 2021

@drspangle cool, i can add it if you make me maintainer

@leonhma leonhma closed this Jul 12, 2021
@leonhma leonhma reopened this Jul 12, 2021
@darigovresearch darigovresearch added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 8, 2021
@darigovresearch
Copy link
Collaborator

Hopefully the discussion in #48 will help move this forwards

@leonhma
Copy link
Contributor Author

leonhma commented Aug 29, 2021

@drspangle already set up the docs on RTD (you can see them here: https://infidel-sensor.readthedocs.io/, maybe add that link as the homepage). So it's set up, the firmware documentation is added with this pr and still has to be merged. It seems like @CCMCAGP noticed some unclear instructions, maybe he will help rephrase some of them later on.

Sorry if you may not hear back from me for the next week, I'm on vacation with my family and mobile network is kinda spotty here :/

@darigovresearch
Copy link
Collaborator

All good, thanks @leonhma for the context & no worries if you're on holiday. I would suggest then @drspangle to merge this pull request if you're happy. @CCMCAGP can make a pull request on the latest version when merged & I can update the documentation link from the readme in another pull request.

@drspangle does this work for you?

@darigovresearch
Copy link
Collaborator

Link to the docs has been updated via #61 . @drspangle can you advise on the above?

@drspangle
Copy link
Owner

drspangle commented Nov 21, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants