feat: Simplify Custom Elements rendering in components. #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fago
reviewed
Oct 29, 2025
| slots: { | ||
| image: '<img loading="lazy" src="https://placehold.co/600x400" width="600" height="400" alt="test" />', | ||
| body: { | ||
| element: 'node', |
Contributor
There was a problem hiding this comment.
this is bad example. a node-element is usually not wrapped in a node element. rather us a drupal-markup here.
also "unified" is a bad name, call it explicit.
fago
reviewed
Oct 29, 2025
| if (customElements?.slots && Object.keys(customElements?.slots)?.length) { | ||
| Object.entries(customElements?.slots).forEach(([key, element]) => { | ||
| const rendered = renderCustomElements(element) | ||
| slots[key] = rendered ? () => h(rendered) : null |
Contributor
There was a problem hiding this comment.
renderCustomElements already returns the return value of h() - so why are we wrapping it in another h() ?
Contributor
|
thanks for the start! I've taken this and made a fully-fledged PR, please see #402 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for the issue: #394.