Fix evaluation of args.convert_to_tflite in train.py#308
Open
gtjoseph wants to merge 1 commit intodscripka:mainfrom
Open
Fix evaluation of args.convert_to_tflite in train.py#308gtjoseph wants to merge 1 commit intodscripka:mainfrom
gtjoseph wants to merge 1 commit intodscripka:mainfrom
Conversation
The boolean command line arguments are all stored as strings so `if args.convert_to_tflite:` always evaluates to True. This has been changed to `if args.convert_to_tflite is True:` to match the handling of the other command line arguments. Resolves: dscripka#305
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The boolean command line arguments are all stored as strings so
if args.convert_to_tflite:always evaluates to True.This has been changed to
if args.convert_to_tflite is True:to match the handling of the other command line arguments.
Resolves: #305