fix: Correct allowed paths / nonexistent paths behavior for reference-all#18
Merged
dsillman2000 merged 2 commits intomainfrom Mar 2, 2026
Merged
Conversation
…s and add related tests. Update readme badge to reflect 0.2.6-4 spec compliance
Contributor
There was a problem hiding this comment.
Pull request overview
Updates !reference-all path handling to comply with the updated yaml-reference spec, specifically around glob results that are empty or include disallowed/nonexistent paths.
Changes:
- Added
_is_path_allowed()to enable non-raising allow-path filtering for glob matches. - Changed
!reference-allresolution to return[](silent omission) when a glob matches zero files or when all matches are disallowed. - Updated unit tests and README documentation to reflect the new silent-omission semantics and spec version.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
yaml_reference/__init__.py |
Implements silent-omission semantics for !reference-all and adds a non-raising allow-path filter. |
tests/unit/test_reference.py |
Adjusts expectations and adds coverage for empty globs and allowed/disallowed glob match scenarios. |
README.md |
Documents the updated !reference-all glob behavior and bumps referenced spec badge version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compliance with changes in specs PR:
dsillman2000/yaml-reference-specs#26