Some optimizations, systemd service, native socket, and rpm spec file #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. removed references to netcat executable 2. implemented stats callback code as python sockets 3. added some exceptions to warning log 4. if warnings enabled, print out the warning log of caught exceptions
`/etc/issue` isn't a good way to obtain release information as [outlined in this blog][1]. Therefore, I'm reading it from `/etc/os-release` which appears to be in: * CentOs * Fedora * RHEL * Ubuntu If that fails, then it continues to read from `/etc/issue` [1]: https://gerardnico.com/linux/version
* Was missing the profile.d in the build. * changed the MemoryHigh to MemoryLimit as systemd doesn't understand it on RHEL 7.5
Added systemd spec file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't look like you've updated the project in a few years, but I figured I'd see if you wanted to merge this PR.
I needed a better way to automate the installing of the program on new personal machines, so I started out writing a systemd services file, which then led to writing an rpm .spec file, and finally lead me to researching why the network stats weren't working on my system.
--warnis enabled..specand.servicefiles.Anyways, I hope you find this PR useful and decide to merge it!
Thanks!