Adjust tests to reflect OpenStruct changes on Ruby3.0 #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref.: ruby/psych#540 OpenStruct on Ruby3.0 changed its marshalling/unmarshalling code, which is now impacting safe_yaml's testcase. The two adjustments that needed to be made are: - OpenStruct's instance_variable_get will now symbolize its hash keys, instead of using strings. - OpenStruct's to_yaml method will not output the 'table' entity anymore. Signed-off-by: Sergio Durigan Junior <sergiodj@sergiodj.net>
sergiodj
force-pushed
the
adjust-tests-ostruct-ruby3.0
branch
from
09834c7 to
024c5c6
Compare
Author
|
Honestly, I am not entirely sure this is the right fix for this issue. Either way, I defer to the opinion of the Ruby experts that will |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref.: ruby/psych#540
OpenStruct on Ruby3.0 changed its marshalling/unmarshalling code,
which is now impacting safe_yaml's testcase. The two adjustments that
needed to be made are:
OpenStruct's
instance_variable_getwill now symbolize its hash keys,instead of using strings.
OpenStruct's
to_yamlmethod will not output thetableentityanymore.