Optimize PitRemove algorithm #239
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified PitRemove algorithm to only update neighbors of points that have changed. Old algorithm would check every point that not had all water removed on every pass, which was very slow for large input DEMs with large pit areas. New algorithm uses a priority queue to order updates by lowest filled elevation, which for a serial run will update each point only once, and is better for parallel runs also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified PitRemove algorithm to only update neighbors of points that
have changed. Old algorithm would check every point that not had
all water removed on every pass, which was very slow for large input
DEMs with large pit areas. New algorithm uses a priority queue to
order updates by lowest filled elevation, which for a serial run will
update each point only once, and is better for parallel runs also.