Scorecard and amdar bugfixes#49
Merged
mollybsmith-noaa merged 10 commits intodevelopmentfrom Apr 2, 2026
Merged
Conversation
| const plotFormat = matsPlotUtils.getPlotFormat(); | ||
| if (curves.length > 1) { | ||
| if (plotFormat !== matsTypes.PlotFormats.none) { | ||
| if (plotFormat && plotFormat !== matsTypes.PlotFormats.none) { |
Contributor
There was a problem hiding this comment.
This doesn't seem right... double validation of the same thing? Or am I missing something?
Collaborator
Author
|
The negative sign on the left indicates that the “if (plotFormat !== matsTypes.PlotFormats.none) {” is being removed, and the plus sign indicates that “if (plotFormat && plotFormat !== matsTypes.PlotFormats.none) {“ is being added, so they’re not both there at the same time. Is that what you were asking?
The change itself is being made because before we were only checking to see if plotFormat was set to none, but we first need to check if it even exists in the first place, and then we can check if the user set it to none. This isn’t None like python has (javascript uses null instead), it’s an actual value that the user can choose.
Does this answer your question?
Thanks for reviewing!
Molly
… On Apr 2, 2026, at 10:09 AM, Jeff Hamilton ***@***.***> wrote:
@JeffHamiltonNOAA commented on this pull request.
In meteor_packages/mats-common/imports/startup/client/curve_util.js <#49?email_source=notifications&email_token=AHBWGZOHT4MVWON3NCVPDQD4T2GCFA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBVGE3DSMBUHAZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K64DSL5ZGK5TJMV3V6Y3MNFRWW#discussion_r3028980067>:
> @@ -406,7 +406,7 @@ const checkDiffs = function () {
const curves = Session.get("Curves");
const plotFormat = matsPlotUtils.getPlotFormat();
if (curves.length > 1) {
- if (plotFormat !== matsTypes.PlotFormats.none) {
+ if (plotFormat && plotFormat !== matsTypes.PlotFormats.none) {
This doesn't seem right... double validation of the same thing? Or am I missing something?
—
Reply to this email directly, view it on GitHub <#49?email_source=notifications&email_token=AHBWGZP3GCQUADQM5QKEGY34T2GCFA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBVGE3DSMBUHAZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2L24DSL5ZGK5TJMV3V63TPORUWM2LDMF2GS33OONPWG3DJMNVQ#pullrequestreview-4051690482>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHBWGZI6RRR2QC37H4GHYU34T2GCFAVCNFSM6AAAAACXJ22XGOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DANJRGY4TANBYGI>.
You are receiving this because you authored the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves both the scorecard and AMDAR (MET-Surface) apps.