Feature #573 Wind Rose, MPR, Hovmoeller, TCMPR, 2D Histogram#574
Open
georgemccabe wants to merge 68 commits intofeature_557_line_gpmfrom
Open
Feature #573 Wind Rose, MPR, Hovmoeller, TCMPR, 2D Histogram#574georgemccabe wants to merge 68 commits intofeature_557_line_gpmfrom
georgemccabe wants to merge 68 commits intofeature_557_line_gpmfrom
Conversation
… base functionality to prepare for plotly to matplotlib transition
…wise use global pyplot -- still close all global pyplot in case anything is lingering after plotting. Add empty write_output_file function that can be override by child classes
… involved updating the wind rose plot to take an optional matplotlib Axes object so the MPR plot could create multiple sub-plots within a single image and pass the appropriate sub-plot object to wind rose to create the plot.
…ogic to function that builds series list instead of plotting function
…ebugging failures
…og level here is ignored if the logger has already been initialized, e.g. in the pytest fixture that sets log level
…ettings in this yaml. point is already tested in another yaml. a new yaml will need to be created to test the tcmpr scatter plot
… this in unit test
…printing exception text
… -- this was needed to support legacy hovmoeller plot yaml files because they use pixel units
…r of colors in the color palette - 1
… the code (except for the correlation computation and plot) was ported over to metplotpy/plots/hovmoeller
… line call to download the artifacts. Update upload action to version that does not have Node.js 20 deprecation warning
…to read data into test -- that test is skipped when the env var is unset
…or-coded n_stat values for tcmpr point plots
…tion instead of trying to log it since the logger isn't available. This could be refactored so that exception can be logged - perhaps by separating the plot object initialization from the series generation and plotting logic
…ridden in the TCMPR plotter to display color-coded number of stats for each series
…ue doesn't need to be passed around. Add slightly more space between NStats label and the numbers
… into multiple lines only if title length is greater than a threshold
bikegeek
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created off of
feature_557_line_gpmbecause PR #571 is still unmerged. This can be adjusted to merge intofeature_555_replace_plotlyonce that is merged.Pull Request Testing
Describe testing already performed for these changes:
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Do these changes include sufficient testing updates? [Yes or No]
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [Yes or No]
If yes, please describe:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases