refactoring: make algorytm more flexible #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtoriki
force-pushed
the
wip/dnci
branch
6 times, most recently
from
e7fa176 to
19e720d
Compare
dtoriki
force-pushed
the
wip/dnci
branch
2 times, most recently
from
397ecc8 to
c267754
Compare
dtoriki
force-pushed
the
wip/dnci
branch
7 times, most recently
from
001fdb2 to
277bf50
Compare
sSadin
reviewed
Sep 4, 2020
Comment on lines
13
to
22
| jobs: | ||
| - name: restore | ||
| configuration: Release | ||
| - name: Hello! It's me2! | ||
| definitions: | ||
| - src/DotNetCI/src/DotNetCI.Config | ||
| - src/DotNetCI/src/DotNetCI.Engine | ||
| jobs: | ||
| - name: restore | ||
| - configuration: Release |
Collaborator
There was a problem hiding this comment.
я не в курсе синтаксиса jml, но кажись здесь что-то с форматированием?
sSadin
reviewed
Sep 4, 2020
Comment on lines
7
to
9
| public IEnumerable<string> Variables { get; set; } = new List<string>(); | ||
| public RunOptions RunOptions { get; set; } = new RunOptions(); | ||
| public IEnumerable<CITaskConfig> Tasks { get; set; } = new List<CITaskConfig>(); |
Collaborator
There was a problem hiding this comment.
Вот вопрос: насколько нам здесь нужны property, вместо field?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not for aproove. Pending for work ends