Check libcurl return value #138
Open
+51
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentiny
force-pushed
the
hjiang/check-libcurl-return
branch
from
fca51f5 to
3e98332
Compare
dentiny
commented
Sep 27, 2025
Collaborator
|
I think first point is valid, unsure if it should be a D_ASSERT (meaning only there on relassert) or then a throw of some kind (unsure which), so that is visible to all users. Second split-off PR has already been merged. Third I guess so. |
Contributor
Author
The reason I use check failure here is: we're simply setting configs for curl handle, and they're not expected to fail. |
Contributor
Author
|
Current implementation is actually buggy:
|
Mytherin
added a commit
to duckdb/duckdb
that referenced
this pull request
Oct 13, 2025
The motivation comes from duckdb/duckdb-httpfs#138 where I do want to validate against all curl-related functions' return value to act as sanity check and shall never fail, not only for debug build, but also for release build. One thing I feel painful when I was writing extension, more often than not, I wrote statements like ```cpp D_ASSERT(do_something_and_return()); ``` which gets skipped in release build :( This PR adds a new assertion macro, which always triggers whatever build type it is, to act as a sanity check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
duckdbnamespace