SERP Settings Sync: Hide search section in AI Features #7041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikescamell
force-pushed
the
feature/mike/serp-settings-sync/hide-search-section-when-launching-from-serp
branch
2 times, most recently
from
b2898fa to
b80eeeb
Compare
The logic for showing or hiding the "AI Chat for Search" settings section has been extracted into a new private function, `renderSearchSettingsSection`.
…in OpenNativeSettingsHandler
mikescamell
force-pushed
the
feature/mike/serp-settings-sync/hide-search-section-when-launching-from-serp
branch
from
b80eeeb to
88863d2
Compare
mikescamell
force-pushed
the
feature/mike/serp-settings-sync/hide-search-section-when-launching-from-serp
branch
from
88863d2 to
18a2c36
Compare
mikescamell
deleted the
feature/mike/serp-settings-sync/hide-search-section-when-launching-from-serp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207908166761516/task/1211794252593377?focus=true
Description
Added support for launching DuckChat settings with native settings only. This PR introduces:
DuckChatNativeSettingsNoParamsactivity parameter to launch DuckChat settings with search section hiddenDuckChatSettingsViewModelto use assisted injection for configuring visibility of the search sectionOpenNativeSettingsHandlerto use the new parameter when launching AI features settingsSteps to test this PR
See Asana task
UI changes
Search section hidden when accessed from SERP